Align name of Forward enum variant for RNN ops with ONNX attribute value
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value Fix an error when converting LSTM / GRU operators with a direction attribute of "forward", or with no direction specified, as "forward" is the default. The enum name was previously `Forwards`, so the conversion code expected an attribute value of `forwards`. The problem was spotted when converting the `decoder_iter.onnx` model from https://github.com/xd009642/xd-tts/tree/master/models/tacotron2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an error when converting LSTM / GRU operators with a direction attribute of
"forward", or with no direction specified, as "forward" is the default. The
enum name was previously
Forwards, so the conversion code expected anattribute value of
forwards.The problem was spotted when converting the
decoder_iter.onnxmodel fromhttps://github.com/xd009642/xd-tts/tree/master/models/tacotron2.