Add AVX-512 implementations of SimdFloat, SimdInt. Use them for GEMM. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is behind an `avx512` feature, since it requires nightly Rust. Operation dispatch using AVX-512 is not implemented yet, so functions like exp, softmax etc. still use AVX2.
This brings the AVX-512 implementation into line with other instruction sets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the AVX-512 GEMM microkernel to match the other microkernels by using the generic SIMD implementation. In the process implement SimdInt, SimdFloat traits for AVX-512 vectors. This is a step towards AVX-512 implementations of the various math functions in rten-vecmath.