Make various iterators generic over the tensor layout #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndex` A layout has two functions: 1) defining the shape of a tensor and 2) the mapping between indices and offsets. Given (2), a method to map between index and offset is something the trait should obviously have, and enables writing more code that works generically with different layouts. Adding this required removing some bounds from `Layout::Index` which are apparently not needed any longer.
The same thing can be accomplished by converting to a static view with `Tensor::nd_view` and then slicing.
This aligns with `into_shape`.
This trait was just a wrapper around `AsRef<[usize]>`. The indirection doesn't appear to be useful any more.
This enables using it for `NdLayout`.
This will enable using them with NdLayout.
This is work towards unifying `NdTensorBase` and `TensorBase` into one struct.
This enables writing methods like `NdTensor::get` that are generic over the layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some preparation for unifying the
TensorBaseandNdTensorBasestructs, in order to enforce a more consistent API between them.There are also some small API changes to the existing APIs of
NdLayout/DynLayoutandTensorBase/NdTensorBaseto prepare for a unified API, including some removal of APIs that are no longer used internally.