Fix 1D conv failing with non-contiguous inputs #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-contiguous 1D views cannot be reshaped without a copy. However we only need to insert an axis, which can be done on non-contiguous views. Both 1D and 2D convolution also failed if the kernel was not contiguous, except for the pointwise and depthwise cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-contiguous 1D views cannot be reshaped without a copy. However we only need to insert an axis, which can be done on non-contiguous views.
Both 1D and 2D convolution also failed if the kernel was not contiguous, except for the pointwise and depthwise cases.