Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/mx-1664-use-wikidata-helper #279

Merged
merged 31 commits into from
Dec 10, 2024
Merged

Conversation

esinsj
Copy link
Contributor

@esinsj esinsj commented Nov 8, 2024

Changes

extractors now use wikidata helper function

Fixed

  • typo sySnopse

Copy link
Contributor

@cutoffthetop cutoffthetop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i have just a formality: could you update the CHANGELOG and pr-description please?

and one other thing i noticed while reviewing:
these wikidata fixtures here https://github.com/robert-koch-institut/mex-extractors/blob/feature/mx-1664-use-wikidata-helper/tests/conftest.py#L44-L119 seem to be an exact copy of https://github.com/robert-koch-institut/mex-common/blob/0.42.0/mex/common/testing/plugin.py#L125-L193
could you trash those fixtures in mex-extractors (along with the test_data folder) and check if the tests still work? in theory they should, since the mex-common fixtures are loaded as a plugin anyway.

tests/ff_projects/test_extract.py Show resolved Hide resolved
@esinsj esinsj requested a review from cutoffthetop December 10, 2024 10:55
@esinsj
Copy link
Contributor Author

esinsj commented Dec 10, 2024

looks good! i have just a formality: could you update the CHANGELOG and pr-description please?

and one other thing i noticed while reviewing: these wikidata fixtures here https://github.com/robert-koch-institut/mex-extractors/blob/feature/mx-1664-use-wikidata-helper/tests/conftest.py#L44-L119 seem to be an exact copy of https://github.com/robert-koch-institut/mex-common/blob/0.42.0/mex/common/testing/plugin.py#L125-L193 could you trash those fixtures in mex-extractors (along with the test_data folder) and check if the tests still work? in theory they should, since the mex-common fixtures are loaded as a plugin anyway.

I left in the extracted_organization_rki, because that wasn't specified in the mex-common fixtures, but is used by the extractor test.

@esinsj esinsj merged commit a717b4d into main Dec 10, 2024
4 checks passed
@esinsj esinsj deleted the feature/mx-1664-use-wikidata-helper branch December 10, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants