Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/mx-1711 prepare artificial data extractor for roundtrip workflow #268

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Nov 4, 2024

PR Context

  • main motivation was to restore determinism, ie running artificial extractor twice with same seed should get you the exact same data. this was ruined by the weight per types, i reckoned. at least after removing that i did get consistent data. i also removed and fixed some unused config options.

Changes

  • increase minimum valid artificial data count to two times the number of entity types

Removed

  • remove matched setting for the artificial extractor, since that was not implemented
  • stop configuring entity-type weights for artificial data, since that broke determinism
  • removed unused -c alias for the count setting of the artificial extractor

Copy link
Contributor

@erichesse erichesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright looks good!

@cutoffthetop cutoffthetop merged commit 53b9da2 into main Nov 6, 2024
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1711-prep-artificial branch November 6, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants