Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mx 1586 wrap up seq repo #106

Merged
merged 23 commits into from
Jun 26, 2024
Merged

Feature/mx 1586 wrap up seq repo #106

merged 23 commits into from
Jun 26, 2024

Conversation

mr-kamran-ali
Copy link
Contributor

@mr-kamran-ali mr-kamran-ali commented Jun 20, 2024 •
edited
Loading

There were issues pointed in wrap-up, this PR fixes these issues:

  • duplicate activities
  • distributions not matching in numbers with resources

Changes

  • combine seq-repo distribution and resource extraction in one asset
  • duplicate seq-repo activities are filtered out

erichesse and others added 19 commits June 10, 2024 14:30
@erichesse
extract v
c165174
@erichesse
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ex…
c8f42cf 
…tractors into feature/mx_1537_extract_voxco_data
@erichesse
add tests
8d4b8fb
@erichesse
consolidate mocked drop
016217b
@erichesse
fix conftest
93ea9c9
@erichesse
update changelog
29c008c
@erichesse
update readme
1ce40fd
@erichesse
add init file to test folder
0db716d
@erichesse
Merge branch 'main' into feature/mx_1537_extract_voxco_data
1fa9d2e 
Signed-off-by: erichesse <[email protected]>
@erichesse
Merge branch 'main' into feature/mx_1537_extract_voxco_data
9339640
@erichesse @mr-kamran-ali
Update CHANGELOG.md
030339c 
Co-authored-by: Kamran Ali <[email protected]>
Signed-off-by: erichesse <[email protected]>
@erichesse @mr-kamran-ali
Update tests/drop/mocked_drop.py
f12c58d 
Co-authored-by: Kamran Ali <[email protected]>
Signed-off-by: erichesse <[email protected]>
@erichesse
semiautomatic linting
252cdf6
@erichesse
spacing in changelog
23ea0e6
@mr-kamran-ali
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ex…
6883b35 
…tractors into feature/mx-1586-wrap-up-seq-repo
@mr-kamran-ali
filter activity to unique only
f069e58
@mr-kamran-ali
transform resource and distribution in one asset
9581ab5
@mr-kamran-ali
update changelog
ce238ed
@mr-kamran-ali
update changelog
f68288e
@mr-kamran-ali mr-kamran-ali self-assigned this Jun 20, 2024
@mr-kamran-ali mr-kamran-ali requested a review from erichesse June 26, 2024 08:28
erichesse
erichesse reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@erichesse erichesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small suggestions to the docstrings, otherwise it looks great

mex/seq_repo/transform.py Outdated Show resolved Hide resolved
mex/seq_repo/transform.py Outdated Show resolved Hide resolved
erichesse
erichesse approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@erichesse erichesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, ready to merge!

@mr-kamran-ali mr-kamran-ali merged commit 4e2a348 into main Jun 26, 2024
7 checks passed
@mr-kamran-ali mr-kamran-ali deleted the feature/mx-1586-wrap-up-seq-repo branch June 26, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erichesse erichesse erichesse approved these changes

Assignees

@mr-kamran-ali mr-kamran-ali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr-kamran-ali @erichesse