feature/mx-1381 prepare database model rework #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmon into feature/mx-1381-prep-rule-endpoint
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.2.0...2.2.1) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…prep-rule-endpoint
cutoffthetop
changed the base branch from
main
to
feature/mx-1562-code-maintenance
cutoffthetop
added a commit
that referenced
this pull request
Feb 22, 2024
# PR Context - preparation for mx-1381 and to keep #69 smaller - already removing public-api module for mx-1562, not closing that ticket yet though # Changes - update cruft and dev dependencies - randomize test order by default # Removed - remove `mex.common.public_api` module and the correlating sinks - remove `PathWrapper.resolve` and `PathWrapper.raw` methods --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…mmon into feature/mx-1381-prep-rule-endpoint
cutoffthetop
changed the title
…mmon into feature/mx-1381-prep-rule-endpoint
…mmon into feature/mx-1381-prep-rule-endpoint
…om/robert-koch-institut/mex-common into feature/mx-1381-prep-rule-endpoint
cutoffthetop
added a commit
to robert-koch-institut/mex-extractors
that referenced
this pull request
Mar 5, 2024
# PR Context - establish compatibility to robert-koch-institut/mex-common#69 # Changes - update cruft template with new linters - utilize new, more precise Identifier subclasses - make pyodbc a soft dependency (only pipelines that use it may fail) # Removed - remove sync-persons pipeline, stopgap mx-1572 - remove `public` as a valid sink option # Fixed - fix some docstring indents and typings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Context
Added
entityTypetype hint toMExModel(nowBaseEntity)AnyBaseModel,AnyExtractedModelandAnyMergedModelIdentifier(for extracted and merged)Identifiersubclasses inmex.common.typesChanges
contextvars.ContextVarformex.common.context.ContextStorestableTargetIdproperty from base models to extracted modelsAnnotated[..., Field(...)]notation for pydantic field configsmex.common.models.baseand move outMExModelandJsonSchemaGeneratorMExModeltoBaseEntitywith only type hints an model confighadPrimarySource,identifierandidentifierInPrimarySourceas frozenRemoved
BaseExtractedDataintoExtractedDatastableTargetIdproperty from merged models