Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1500 speed-up wikidata tests #68

Merged
merged 5 commits into from
Jan 23, 2024
Merged

feature/mx-1500 speed-up wikidata tests #68

merged 5 commits into from
Jan 23, 2024

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Jan 22, 2024 •
edited
Loading

PR Context

  • profiling the tests with cProfile and snakeviz showed wikidata tests are only slow because of HTTP requests
  • we checked the tests and they are all valid (no HTTP calls that could be cut from the integration tests)
  • instead we added pytest plugins to randomize order (always good idea to detect bad test isolation) and to distribute test workload to all cpu cores (this should speed up the test runs)

Added

  • pytest plugins for random order and parallelized test execution

Changes

  • .\mex.bat test uses random order and xdist plugins by default

@cutoffthetop cutoffthetop self-assigned this Jan 22, 2024
carolinscholl
carolinscholl approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@carolinscholl carolinscholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes :)

@cutoffthetop cutoffthetop merged commit 7564073 into main Jan 23, 2024
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1500-speed-up-wikidata-tests branch January 23, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinscholl carolinscholl carolinscholl approved these changes

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @carolinscholl