Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1470 Ensure correct types #47

Merged
merged 8 commits into from
Nov 22, 2023
Merged

feature/mx-1470 Ensure correct types #47

merged 8 commits into from
Nov 22, 2023

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Nov 15, 2023 •
edited
Loading

  • ensure correct types for helper extract function in ldap and organigram
  • fix tiny issue with pandas not parsing str subclasses with resolution
  • upgrade to pydantic 2.5
  • remove mypy-extensions dependency
  • upgrade all other dependencies
  • add yaml-checker pre-commit (for .github folder)

@cutoffthetop
Ensure correct id type
8e6c038 
Signed-off-by: Nicolas Drebenstedt <[email protected]>
@cutoffthetop cutoffthetop self-assigned this Nov 15, 2023
@cutoffthetop cutoffthetop changed the title feature/mx-1470 Ensure correct type for unit_merged_ids_by_synonyms feature/mx-1470 Ensure correct types Nov 20, 2023
erichesse
erichesse reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@erichesse erichesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I just think the docstrings could be slightly more precise as well.

mex/common/ldap/extract.py Outdated Show resolved Hide resolved
mex/common/ldap/extract.py Outdated Show resolved Hide resolved
mex/common/ldap/extract.py Outdated Show resolved Hide resolved
mex/common/ldap/extract.py Outdated Show resolved Hide resolved
erichesse
erichesse reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@erichesse erichesse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix one typo and we are ready to merge: ae2a797#r133237237

@cutoffthetop
Copy link
Contributor Author

Fix one typo and we are ready to merge: ae2a797#r133237237

fixed 16cd80e

erichesse
erichesse approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@erichesse erichesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Ready to merge.

@cutoffthetop cutoffthetop merged commit 5ef55be into main Nov 22, 2023
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1470-fix-id-type branch November 22, 2023 09:27
carolinscholl pushed a commit that referenced this pull request Dec 6, 2023
@cutoffthetop @carolinscholl
feature/mx-1470 Ensure correct types (#47)
472d056 
- ensure correct types for helper extract function in ldap and organigram
- fix tiny issue with pandas not parsing str subclasses with resolution
- upgrade to pydantic 2.5
- remove mypy-extensions dependency
- upgrade all other dependencies
- add yaml-checker pre-commit (for .github folder)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erichesse erichesse erichesse approved these changes

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @erichesse