Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1708 convert sinks to connectors #367

Merged
merged 11 commits into from
Jan 28, 2025
Merged

feature/mx-1708 convert sinks to connectors #367

merged 11 commits into from
Jan 28, 2025

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Jan 16, 2025 •
edited
Loading

PR Context

Added

  • add a sink registry with register_sink and get_sink functions
  • add a MultiSink implementation, akin to mex.extractors.load

Changes

  • BREAKING: convert post_to_backend_api to BackendApiSink
  • BREAKING: convert write_ndjson to NdjsonSink

rababerladuseladim
rababerladuseladim requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I like that you got rid of the chatty watch function on top.

mex/common/sinks/backend_api.py Outdated Show resolved Hide resolved
mex/common/sinks/ndjson.py Outdated Show resolved Hide resolved
mex/common/sinks/backend_api.py Outdated Show resolved Hide resolved
mex/common/sinks/ndjson.py Outdated Show resolved Hide resolved
mex/common/sinks/registry.py Outdated Show resolved Hide resolved
@cutoffthetop cutoffthetop merged commit f702a11 into main Jan 28, 2025
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1708-sinks-as-connectors branch January 28, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rababerladuseladim rababerladuseladim rababerladuseladim approved these changes

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @rababerladuseladim