Feature/mx 1677 orcid extractor

[vyvytranngoc]

PR Context

connector in mex-common that takes a string or orcid ID as argument
returns orcid person
convenience function: search for person, if one is found, transform to ExtractedPerson

Added

• Connector class for retrieving ORCID data by ID or name
• methods for extracting data from orcid
• methods to transform from OcidPerson to mex person
• model class for orcid data
• unit tests

Changes

Deprecated

Removed

Fixed

Security

[vyvytranngoc]

FAILED tests/primary_source/test_extract.py::test_extract_seed_primary_sources - AssertionError: assert 5 == 4
 +  where 5 = len([SeedPrimarySource(identifier='mex', title=[Text(value='Metadata Exchange', language=<TextLanguage.EN: 'en'>)]), SeedPrimarySource(identifier='organigram', title=[Text(value='Organizational Units', language=<TextLanguage.EN: 'en'>)]), SeedPrimarySource(identifier='ldap', title=[Text(value='Active Directory', language=<TextLanguage.EN: 'en'>)]), SeedPrimarySource(identifier='wikidata', title=[Text(value='Wikidata APIs', language=<TextLanguage.EN: 'en'>)]), SeedPrimarySource(identifier='orcid', title=[Text(value='Open Researcher Contributor Identification Initiative', language=<TextLanguage.EN: 'en'>)])])

I think this occurs because I have added orcid as a primary source?

[cutoffthetop]

tests/orcid/model.yaml seems to be empty, did you have plans for that? done ✔️

[cutoffthetop]

FAILED tests/primary_source/test_extract.py::test_extract_seed_primary_sources - AssertionError: assert 5 == 4

I think this occurs because I have added orcid as a primary source?

yep, that's it. feel free to bump the expected length up to 5

[cutoffthetop]

good work already! i found some unused bits and pieces, and i had one bigger issue with the way the orcid models are written. could you take a look at that first?

i didn't review the tests yet, but i think they might change a bit anyway once the models are updated.

[cutoffthetop]

it's coming along! we just need to ensure proper unit test isolation

[vyvytranngoc]

I was running my unit tests after pulling all new changes from main. But now I encounter this error:

mex\common\types\vocabulary.py:71: in <listcomp>
    Concept.model_validate(raw_vocabulary)
E   pydantic_core._pydantic_core.ValidationError: 1 validation error for Concept
E   altLabel
E     Input should be a valid list [type=list_type, input_value={'de': 'RESTful API', 'en': 'RESTful API'}, input_type=dict]
E       For further information visit https://errors.pydantic.dev/2.9/v/list_type

[vyvytranngoc]

But I fixed the requested changes and made sure I'm running unit tests and no integration tests

[cutoffthetop]

a few simplifications and were good to go

[cutoffthetop]

nice! let's merge 🚀