Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/mx-1664-improve-wikidata-convenience-function-for-use-in-extractors #339

Conversation

esinsj
Copy link
Contributor

@esinsj esinsj commented Nov 19, 2024

Changes

wikidata helper optionally accepts wikidata primary source

@esinsj esinsj self-assigned this Nov 19, 2024
Copy link
Contributor

@cutoffthetop cutoffthetop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just 1 test missing

mex/common/wikidata/helpers.py Show resolved Hide resolved
@esinsj esinsj merged commit bb647e8 into main Nov 22, 2024
4 checks passed
@esinsj esinsj deleted the feature/mx-1664-improve-wikidata-convenience-function-for-use-in-extractors branch November 22, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants