Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1663 primary source convenience function #306

Merged
merged 39 commits into from
Oct 22, 2024
Merged

feature/mx-1663 primary source convenience function #306

merged 39 commits into from
Oct 22, 2024

Conversation

esinsj
Copy link
Contributor

@esinsj esinsj commented Oct 16, 2024

Added

  • helper function for primary source look up

Changes

  • wikidata convenience function split between mex-common and mex-extractors

erichesse and others added 30 commits September 12, 2024 13:33
@erichesse
rework wikidata and add primary source helpers
c9149ce
@erichesse
Merge branch 'feature/model-update-v3' of https://github.com/robert-k…
409f18a 
…och-institut/mex-common into feature/mx-1663_primary_source_convenience_function
@cutoffthetop
add utils for field and type analysis
3ed58e9
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-co…
ea3aeef 
…mmon into feature/mx-1702-field-and-type-utils
@cutoffthetop
update types and schemas
98f9d19
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-co…
77565d1 
…mmon into feature/mx-1702-field-and-type-utils
@cutoffthetop
Merge branch 'feature/mx-1702-field-and-type-utils' into feature/mx-1…
2e8015d 
…702-type-prep
@cutoffthetop
Merge branch 'main' into feature/mx-1702-field-and-type-utils
71803be
@cutoffthetop
Merge branch 'feature/mx-1702-field-and-type-utils' into feature/mx-1…
c50c477 
…702-type-prep
@cutoffthetop
WIP
7987222
@cutoffthetop
WIP
218437e
@cutoffthetop
fix tests
af73923
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-co…
b661613 
…mmon into feature/mx-1702-type-prep
@cutoffthetop
add tests
6220b11
@cutoffthetop
update cl
72faee1
@cutoffthetop
fix import
b8b7937
@esinsj
add test for wikidata convenience helper function
acd2784
@erichesse
add function to make extracted items hashable
d5f966f
@erichesse
Merge branch 'feature/mx-1663_primary_source_convenience_function' of h…
5c20277 
…ttps://github.com/robert-koch-institut/mex-common into feature/mx-1663_primary_source_convenience_function
@cutoffthetop
fix serializer
78b762c
@cutoffthetop
update doc
4799be6
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-co…
fb6b2d0 
…mmon into feature/mx-1702-type-prep
@cutoffthetop
clean up vocabs
227a302
@cutoffthetop
fix url pattern
612c7cc
@esinsj
add test for hashability of ExtractedData
0b91d49
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-co…
f52bc1c 
…mmon into feature/mx-1702-type-prep
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-co…
6c4ab4a 
…mmon into feature/mx-1702-type-prep
@esinsj
add test for primary source helpers
2a537c1
@esinsj
Merge branch 'feature/model-update-v3' into feature/mx-1663_primary_s…
db0af96 
…ource_convenience_function.
@esinsj
Merge branch 'feature/mx-1702-type-prep' into feature/mx-1663_primary…
84a6383 
…_source_convenience_function_with_mx-1702

Signed-off-by: Janina Esins <[email protected]>
@esinsj
Copy link
Contributor Author

esinsj commented Oct 16, 2024

Info: This branch has already parts of MX-1702 merged into it.

@esinsj esinsj changed the base branch from main to feature/model-update-v3 October 16, 2024 16:09
@cutoffthetop cutoffthetop changed the title Feature/mx 1663 primary source convenience function with mx 1702 feature/mx-1663 primary source convenience function Oct 17, 2024
@cutoffthetop cutoffthetop mentioned this pull request Oct 17, 2024
Closed
cutoffthetop
cutoffthetop requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@cutoffthetop cutoffthetop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, looks good so far. i did a bit of merging around to get the diff down in size. now just some changelog updates are needed, and some code de-duplication with the testing.plugin would be cool

mex/common/primary_source/helpers.py Outdated Show resolved Hide resolved
mex/common/wikidata/convenience.py Show resolved Hide resolved
mex/common/models/base/extracted_data.py Show resolved Hide resolved
mex/common/wikidata/helpers.py Outdated Show resolved Hide resolved
@esinsj esinsj merged commit adafc92 into feature/model-update-v3 Oct 22, 2024
4 checks passed
@esinsj esinsj deleted the feature/mx-1663_primary_source_convenience_function_with_mx-1702 branch October 22, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cutoffthetop cutoffthetop cutoffthetop requested changes

Assignees

@esinsj esinsj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esinsj @cutoffthetop @erichesse