lint

tests/backend_api/conftest.py

@@ -6,7 +6,7 @@
 from mex.common.backend_api.connector import BackendApiConnector
 
 
-@pytest.fixture()
+@pytest.fixture
 def mocked_backend(monkeypatch: MonkeyPatch) -> MagicMock:
     """Return the mocked request dispatch method of backend connector."""
     mocked_send_request = MagicMock(

tests/conftest.py

@@ -23,7 +23,7 @@
 pytest_plugins = ("mex.common.testing.plugin",)
 
 
-@pytest.fixture()
+@pytest.fixture
 def extracted_person() -> ExtractedPerson:
     """Return a dummy extracted person for testing purposes."""
     return ExtractedPerson.model_construct(
@@ -45,7 +45,7 @@ def extracted_person() -> ExtractedPerson:
     )
 
 
-@pytest.fixture()
+@pytest.fixture
 def merged_person() -> MergedPerson:
     """Return a dummy merged person for testing purposes."""
     return MergedPerson.model_construct(
@@ -64,7 +64,7 @@ def merged_person() -> MergedPerson:
     )
 
 
-@pytest.fixture()
+@pytest.fixture
 def rule_set_request() -> PersonRuleSetRequest:
     """Return a dummy person rule set request for testing purposes."""
     return PersonRuleSetRequest(
@@ -74,7 +74,7 @@ def rule_set_request() -> PersonRuleSetRequest:
     )
 
 
-@pytest.fixture()
+@pytest.fixture
 def rule_set_response() -> PersonRuleSetResponse:
     """Return a dummy person rule set response for testing purposes."""
     return PersonRuleSetResponse(

tests/connector/test_http.py

@@ -17,7 +17,7 @@ def _check_availability(self) -> None:
         self.request("GET", "_system/check")
 
 
-@pytest.fixture()
+@pytest.fixture
 def mocked_dummy_session(monkeypatch: MonkeyPatch) -> MagicMock:
     """Mock the DummyHTTPConnector with a MagicMock session and return that."""
     mocked_session = MagicMock(spec=requests.Session, name="dummy_session")

tests/ldap/conftest.py

@@ -51,7 +51,7 @@
 }
 
 
-@pytest.fixture()
+@pytest.fixture
 def ldap_mocker(monkeypatch: MonkeyPatch) -> LDAPMocker:
     """Patch the LDAP connector to return `SAMPLE_PERSON_ATTRS` from its connection."""
 

tests/ldap/test_connector.py

@@ -48,7 +48,7 @@ def test_get_persons_mocked(ldap_mocker: LDAPMocker) -> None:
         "nonexistent_person",
     ],
 )
-@pytest.mark.integration()
+@pytest.mark.integration
 def test_get_persons_ldap(kwargs: dict[str, str], pattern: str) -> None:
     connector = LDAPConnector.get()
     persons = list(connector.get_persons(**kwargs))
@@ -68,7 +68,7 @@ def test_get_persons_ldap(kwargs: dict[str, str], pattern: str) -> None:
         "nonexistent_functional_account",
     ],
 )
-@pytest.mark.integration()
+@pytest.mark.integration
 def test_get_functional_accounts_ldap(kwargs: dict[str, str], pattern: str) -> None:
     connector = LDAPConnector.get()
     functional_accounts = list(connector.get_functional_accounts(**kwargs))

tests/ldap/test_extract.py

@@ -17,14 +17,14 @@
 from tests.ldap.conftest import SAMPLE_PERSON_ATTRS, LDAPMocker
 
 
-@pytest.fixture()
+@pytest.fixture
 def ldap_primary_source(
     extracted_primary_sources: dict[str, ExtractedPrimarySource],
 ) -> ExtractedPrimarySource:
     return extracted_primary_sources["ldap"]
 
 
-@pytest.fixture()
+@pytest.fixture
 def ldap_person_with_identity(
     ldap_primary_source: ExtractedPrimarySource,
 ) -> LDAPPerson:
@@ -40,14 +40,14 @@ def ldap_person_with_identity(
     return person
 
 
-@pytest.fixture()
+@pytest.fixture
 def ldap_person_with_identity_with_query(
     ldap_person_with_identity: LDAPPerson,
 ) -> LDAPPersonWithQuery:
     return LDAPPersonWithQuery(person=ldap_person_with_identity, query="foo")
 
 
-@pytest.fixture()
+@pytest.fixture
 def ldap_person_without_identity() -> LDAPPerson:
     return LDAPPerson(
         objectGUID=UUID(int=2, version=4),
@@ -58,14 +58,14 @@ def ldap_person_without_identity() -> LDAPPerson:
     )
 
 
-@pytest.fixture()
+@pytest.fixture
 def ldap_person_without_identity_with_query(
     ldap_person_without_identity: LDAPPerson,
 ) -> LDAPPersonWithQuery:
     return LDAPPersonWithQuery(person=ldap_person_without_identity, query="foo")
 
 
-@pytest.fixture()
+@pytest.fixture
 def ldap_persons(
     ldap_person_with_identity: LDAPPerson, ldap_person_without_identity: LDAPPerson
 ) -> list[LDAPPerson]:
@@ -75,7 +75,7 @@ def ldap_persons(
     ]
 
 
-@pytest.fixture()
+@pytest.fixture
 def ldap_persons_with_query(
     ldap_person_with_identity_with_query: LDAPPersonWithQuery,
     ldap_person_without_identity_with_query: LDAPPersonWithQuery,
@@ -86,7 +86,7 @@ def ldap_persons_with_query(
     ]
 
 
-@pytest.fixture()
+@pytest.fixture
 def merged_id_of_person_with_identity(
     ldap_person_with_identity: LDAPPerson,
     ldap_primary_source: ExtractedPrimarySource,

tests/ldap/test_transform.py

@@ -15,7 +15,7 @@
 from mex.common.testing import Joker
 
 
-@pytest.fixture()
+@pytest.fixture
 def extracted_unit(
     extracted_primary_sources: dict[str, ExtractedPrimarySource],
 ) -> ExtractedOrganizationalUnit:

tests/organigram/conftest.py

@@ -8,7 +8,7 @@
 from mex.common.types import Link, LinkLanguage, Text
 
 
-@pytest.fixture()
+@pytest.fixture
 def child_unit() -> OrganigramUnit:
     """Return a child unit corresponding to the test_data."""
     return OrganigramUnit(
@@ -28,7 +28,7 @@ def child_unit() -> OrganigramUnit:
     )
 
 
-@pytest.fixture()
+@pytest.fixture
 def extracted_child_unit(
     child_unit: OrganigramUnit,
     extracted_primary_sources: dict[str, ExtractedPrimarySource],
@@ -41,7 +41,7 @@ def extracted_child_unit(
     )
 
 
-@pytest.fixture()
+@pytest.fixture
 def parent_unit() -> OrganigramUnit:
     """Return a parent unit corresponding to the test_data."""
     return OrganigramUnit(
@@ -62,7 +62,7 @@ def parent_unit() -> OrganigramUnit:
     )
 
 
-@pytest.fixture()
+@pytest.fixture
 def extracted_parent_unit(
     parent_unit: OrganigramUnit,
     extracted_primary_sources: dict[str, ExtractedPrimarySource],

tests/test_settings.py

@@ -52,7 +52,7 @@ def test_settings_getting_caches_singleton() -> None:
     assert settings_fetched_again is settings
 
 
-@pytest.mark.integration()
+@pytest.mark.integration
 def test_parse_env_file() -> None:
     settings = BaseSettings.get()
     # "work_dir" and "assets_dir" are always set, assert that more than these two are

tests/types/test_vocabulary.py

@@ -17,7 +17,7 @@ def test_split_to_caps(string: str, expected: str) -> None:
     assert split_to_caps(string) == expected
 
 
-@pytest.fixture()
+@pytest.fixture
 def use_dummy_vocabulary(monkeypatch: MonkeyPatch) -> None:
     dummy_vocabulary = VocabularyLoader.parse_file(
         str(TESTDATA_DIR / "dummy-vocabulary.json")

tests/wikidata/conftest.py

@@ -13,7 +13,7 @@
 TESTDATA_DIR = Path(__file__).parent / "test_data"
 
 
-@pytest.fixture()
+@pytest.fixture
 def mocked_session_wikidata_query_service(monkeypatch: MonkeyPatch) -> MagicMock:
     """Mock and return WikidataQueryServiceConnector with a MagicMock session."""
     mocked_session = MagicMock(spec=requests.Session)
@@ -25,7 +25,7 @@ def __init__(self: WikidataQueryServiceConnector) -> None:
     return mocked_session
 
 
-@pytest.fixture()
+@pytest.fixture
 def mocked_session_wikidata_api(monkeypatch: MonkeyPatch) -> MagicMock:
     """Mock and return WikidataAPIConnector with a MagicMock session."""
     mocked_session = MagicMock(spec=requests.Session)

tests/wikidata/test_connector.py

@@ -20,7 +20,7 @@ def test_initialization_mocked_server(
     assert connector._check_availability() is None
 
 
-@pytest.mark.integration()
+@pytest.mark.integration
 def test_get_data_by_query() -> None:
     """Test if items can be searched providing a label."""
     expected = [
@@ -110,7 +110,7 @@ def test_get_data_by_query_mocked(
     assert response == expected
 
 
-@pytest.mark.integration()
+@pytest.mark.integration
 def test_get_wikidata_item_details_by_id() -> None:
     """Test if items details can be fetched by its ID."""
     connector = WikidataAPIConnector.get()

tests/wikidata/test_convenience.py

@@ -119,7 +119,7 @@ def test_get_merged_organization_id_by_query_with_extract_transform_and_load_moc
     load_function.assert_not_called()
 
 
-@pytest.mark.integration()
+@pytest.mark.integration
 def test_get_merged_organization_id_by_query_with_extract_transform_and_load(
     extracted_primary_sources: dict[str, ExtractedPrimarySource],
 ) -> None:

tests/wikidata/test_extract.py

@@ -19,7 +19,7 @@
 from tests.wikidata.conftest import TESTDATA_DIR
 
 
-@pytest.mark.integration()
+@pytest.mark.integration
 def test_search_organization_by_label() -> None:
     expected = "Q679041"
 
@@ -29,7 +29,7 @@ def test_search_organization_by_label() -> None:
     assert search_result.identifier == expected
 
 
-@pytest.mark.integration()
+@pytest.mark.integration
 def test_search_organizations_by_label() -> None:
     search_result = list(
         search_organizations_by_label(
@@ -50,7 +50,7 @@ def test_search_organizations_by_label() -> None:
     assert search_result[0].labels.model_dump() == labels
 
 
-@pytest.mark.integration()
+@pytest.mark.integration
 def test_get_count_of_found_organizations_by_label() -> None:
     total_found_orgs = get_count_of_found_organizations_by_label(
         item_label='Robert Koch Institute"',
@@ -60,7 +60,7 @@ def test_get_count_of_found_organizations_by_label() -> None:
     assert total_found_orgs == 3
 
 
-@pytest.mark.integration()
+@pytest.mark.integration
 def test_search_organization_by_label_for_none() -> None:
     """Test if None is returned when multiple organizations are found."""
     search_result = search_organization_by_label(
@@ -425,7 +425,7 @@ def mocked_query_response() -> list[dict[str, dict[str, str]]]:
     assert search_result == 3
 
 
-@pytest.mark.integration()
+@pytest.mark.integration
 def test_get_organization_details() -> None:
     expected = {
         "identifier": "Q679041",