Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add consent models and fix temporal type #288

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Sep 16, 2024

Added

  • add consent models for model v3
  • add doi field to resource models

Changed

  • update LOINC pattern

Fixed

  • fix temporal entity schemas

@cutoffthetop cutoffthetop changed the base branch from main to feature/model-update-v3 September 16, 2024 17:11
Copy link
Contributor

@erichesse erichesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update the changelog as well, with the DoiStr which is not mentioned in the PR description as of yet.

mex/common/models/base/schema.py Show resolved Hide resolved
@cutoffthetop
Copy link
Contributor Author

Please update the changelog as well

the v3 branch also doesn't have a changelog yet. that would probably cause a load of merge conflicts anyway. but i added a flashy note to the v3 PR and added the DoiStr to both PR's descriptions

@cutoffthetop cutoffthetop merged commit f97321b into feature/model-update-v3 Sep 24, 2024
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/v3-add-consent-model branch September 24, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants