-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/mx-1702 add utils for field and type analysis #283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just two questions remaining.
And on top of that, is removing the stale code in backend already part of a ticket?
good point, i created a clean-up ticket: MX-1718 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done just one last question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Personally it's fine for me now, however there is a cve scan error I don't understand.
that was just a connection error to the cve database, i re-ran the job and it's green now |
PR Context
Added
contains_only_types
to check if fields are annotated as desiredgroup_fields_by_class_name
utility to simplify filtered model/field lookupsget_inner_types
to customize what to unpack