Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/mx-1702 add utils for field and type analysis #283

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Sep 16, 2024

PR Context

  • these are needed in the editor as well as the backend
  • so we move them from the backend to common

Added

  • contains_only_types to check if fields are annotated as desired
  • group_fields_by_class_name utility to simplify filtered model/field lookups
  • new parameters to get_inner_types to customize what to unpack

Copy link
Contributor

@erichesse erichesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just two questions remaining.

And on top of that, is removing the stale code in backend already part of a ticket?

mex/common/utils.py Show resolved Hide resolved
mex/common/utils.py Show resolved Hide resolved
@cutoffthetop
Copy link
Contributor Author

And on top of that, is removing the stale code in backend already part of a ticket?

good point, i created a clean-up ticket: MX-1718

Copy link
Contributor

@erichesse erichesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done just one last question

mex/common/utils.py Show resolved Hide resolved
Copy link
Contributor

@erichesse erichesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Personally it's fine for me now, however there is a cve scan error I don't understand.

@cutoffthetop
Copy link
Contributor Author

Looks good. Personally it's fine for me now, however there is a cve scan error I don't understand.

that was just a connection error to the cve database, i re-ran the job and it's green now

@cutoffthetop cutoffthetop merged commit bc9f9f8 into main Sep 24, 2024
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1702-field-and-type-utils branch September 24, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants