Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1446 typing improvements #218

Merged
merged 5 commits into from
Jul 10, 2024
Merged

feature/mx-1446 typing improvements #218

merged 5 commits into from
Jul 10, 2024

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Jul 9, 2024 •
edited
Loading

PR Context

  • some type fixes and code cosmetics

Changes

  • improve typing for methods using Self
  • make local type variables private

Fixed

  • fix typing for __eq__ arguments

@cutoffthetop cutoffthetop changed the title Feature/fix typing feature/mx-1446 typing improvements Jul 9, 2024
@cutoffthetop cutoffthetop merged commit 1246867 into main Jul 10, 2024
7 checks passed
@cutoffthetop cutoffthetop deleted the feature/fix-typing branch July 10, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rababerladuseladim rababerladuseladim rababerladuseladim approved these changes

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @rababerladuseladim