Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1477 add ldap tests #169

Merged
merged 11 commits into from
May 13, 2024
Merged

feature/mx-1477 add ldap tests #169

merged 11 commits into from
May 13, 2024

Conversation

rababerladuseladim
Copy link
Contributor

@rababerladuseladim rababerladuseladim commented May 7, 2024 •
edited by cutoffthetop
Loading

PR Context

This PR adds tests for the ldap.extract module.

Changes

  • add tests for ldap.extract

Fixed

  • fix ldap.extract.get_merged_ids_by_email

@cutoffthetop cutoffthetop self-requested a review May 13, 2024 09:33
cutoffthetop
cutoffthetop approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@cutoffthetop cutoffthetop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, much obliged.

@cutoffthetop cutoffthetop merged commit 807450a into main May 13, 2024
7 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1477-add-ldap-tests branch May 13, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cutoffthetop cutoffthetop cutoffthetop approved these changes

Assignees

@rababerladuseladim rababerladuseladim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rababerladuseladim @cutoffthetop