Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mx 1679 ingest wikidata primary source #258

Merged
merged 9 commits into from
Feb 27, 2025
Merged

Feature/mx 1679 ingest wikidata primary source #258

merged 9 commits into from
Feb 27, 2025

Conversation

ZehraVictoria
Copy link
Contributor

PR Context

  • ingest wikidata primary source on search request to ensure import of wikidata items works

rababerladuseladim
rababerladuseladim requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just some minor changes.

rababerladuseladim
rababerladuseladim requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test if the primary source is in the graph after running your code.

rababerladuseladim
rababerladuseladim requested changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge main, and you are good to go!

@ZehraVictoria ZehraVictoria merged commit df28b67 into main Feb 27, 2025
4 checks passed
@ZehraVictoria ZehraVictoria deleted the feature/mx-1679_ingest_wikidata_primary_source branch February 27, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rababerladuseladim rababerladuseladim rababerladuseladim approved these changes

Assignees

@ZehraVictoria ZehraVictoria

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZehraVictoria @rababerladuseladim