-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Make icon components functional #43
Conversation
Great, they ran this time, thanks for reopening! |
@robcresswell I'll look at the tests! 😄 |
Great, thanks; no rush, I'll keep an eye out for when you get chance to do it. And if you get too bogged down in it, yell and I'll take a look. |
Thanks @robcresswell - all done. I've removed the tests on the internal state of the component given that functional components don't have an instance. Let me know if you feel that it needs more tests. |
I think the snapshot is adequate for covering that info, so its all good. Thanks Daniel! I'll merge and tag a release later tonight / tomorrow, depending on time. |
@robcresswell Do you need me to make any further changes? |
@danielroe Thanks for reminding me about this, sorry. Have rolled these into #46. Wanted to rewrite the commit messages to trigger semantic release correctly, without pestering your for further work. |
I kept your commits etc, so the authorship is still under your name. Thanks for your contribution! |
Thanks @robcresswell - and that's kind of you. 😃 |
@danielroe I don't suppose you'd be able to help out with #49 ? No worries if not 😇 |
[Re-submitting #33]
Because functional components don't have the full Vue lifecycle, they seem ideally suited for a project like this one. Let me know if you would like me to make any additional changes to the PR.