Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/env setter #33

Merged
merged 28 commits into from
Sep 10, 2018
Merged

Feature/env setter #33

merged 28 commits into from
Sep 10, 2018

Conversation

wolfy-j
Copy link
Contributor

@wolfy-j wolfy-j commented Sep 10, 2018

No description provided.

@codecov
Copy link

codecov bot commented Sep 10, 2018

Codecov Report

Merging #33 into master will increase coverage by 0.82%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   90.48%   91.31%   +0.82%     
==========================================
  Files          29       29              
  Lines        1188     1209      +21     
==========================================
+ Hits         1075     1104      +29     
+ Misses         68       63       -5     
+ Partials       45       42       -3
Impacted Files Coverage Δ
error_buffer.go 100% <ø> (ø) ⬆️
service/http/config.go 100% <100%> (+23.07%) ⬆️
service/static/config.go 95.23% <100%> (ø) ⬆️
server_config.go 100% <100%> (+9.09%) ⬆️
service/env/service.go 100% <100%> (+18.18%) ⬆️
service/http/service.go 88.88% <100%> (ø) ⬆️
service/rpc/service.go 96% <33.33%> (-4%) ⬇️
service/container.go 90.07% <60%> (-1.3%) ⬇️
worker.go 91.42% <0%> (+1.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea97c18...562464f. Read the comment docs.

@wolfy-j wolfy-j merged commit a554a98 into master Sep 10, 2018
@wolfy-j wolfy-j deleted the feature/env-setter branch September 26, 2018 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant