-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed composer installation in README.md #1869
Conversation
WalkthroughThe recent update streamlines the package installation process for a project by consolidating the required RoadRunner packages into a single Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- README.md (1 hunks)
Additional comments: 1
README.md (1)
- 74-74: The updated Composer command aligns with the PR objectives and the official RoadRunner documentation, ensuring users have a simplified and accurate installation process.
Hey @Filipponik 👋 Thanks for the PR 👍 These deps are not needed to download the RR binary. The installation process describes how to install RR, not a PHP worker. |
@rustatian yeah but i wanted to try roadrunner, then i read README.md for install. Installing via composer doesnt work and dont match web docs |
i mean |
What exactly doesn't match (btw, there is no |
Oh yeah, sorry, you're right. Your PR is good to go, it should be |
@rustatian yeah |
Cool 👍 LGTM, thanks ❤️ |
Reason for This PR
Docs of installation via composer are incorrect and don't even work (maybe just deprecated)
Description of Changes
Changed from
composer require spiral/roadrunner-http spiral/roadrunner-worker nyholm/psr7
tocomposer require spiral/roadrunner-cli
as noted at https://docs.roadrunner.dev/general/installLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit
roadrunner-cli
.