Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance #46

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Maintenance #46

merged 7 commits into from
Jan 28, 2025

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Jan 28, 2025

  • Updated dependencies
  • Applied Spiral Code Style
    • Resolved PHP 8.4 deprecations
  • Added CI actions for CS fixing; psalm
  • Added Funding metadata

Part of roadrunner-php/issues#39

Summary by CodeRabbit

Based on the comprehensive summary of changes, here are the high-level release notes:

  • Configuration Updates

    • Added support for PHP 8.1+
    • Enhanced configuration generation and management
    • Improved code style and static analysis configurations
  • Dependency Management

    • Updated dependencies to latest compatible versions
    • Added new development dependencies for code quality
    • Refined version constraints for existing packages
  • Development Tooling

    • Introduced new GitHub Actions workflows for code style and static analysis
    • Added Psalm baseline for code quality tracking
    • Implemented PHP-CS-Fixer configuration
  • Repository and Asset Management

    • Enhanced flexibility in handling repository and release assets
    • Improved nullable type handling
    • Streamlined asset and release collection methods
  • Platform Support

    • Added support for ARM64 architecture
    • Expanded operating system and architecture detection

These release notes provide a concise overview of the key changes without revealing implementation details.

Copy link

coderabbitai bot commented Jan 28, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a comprehensive set of changes across the RoadRunner project, focusing on code style, type safety, and configuration improvements. The modifications span multiple files and directories, with key updates to configuration handling, repository management, environment settings, and command-line interfaces. The changes primarily involve refactoring method signatures, removing redundant documentation, adding new methods, and enhancing type declarations to improve code clarity and flexibility.

Changes

File/Directory Change Summary
.editorconfig New configuration file establishing coding style guidelines
.gitattributes New file specifying text handling and export-ignore rules
.github/FUNDING.yml Added GitHub sponsorship entry
.github/workflows/ New workflows for code style fixes and static analysis
.gitignore Updated ignored files and directories
composer.json Updated dependencies, PHP version requirement, and scripts
psalm.xml Enhanced static analysis configuration
src/Archive/ Removed PHPDoc comments, updated method signatures
src/Command/ Refined option handling, added nullable type support
src/Configuration/ Added getShortName() methods across section classes
src/Environment/ Updated type declarations and method signatures
src/Repository/ Improved type safety, added nullable parameters

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant CLI as Command Line Interface
    participant Config as Configuration Generator
    participant Repo as Repository
    participant Asset as Asset Downloader

    Dev->>CLI: Execute command
    CLI->>Config: Generate configuration
    Config->>Repo: Fetch releases
    Repo->>Asset: Download binary
    Asset-->>Repo: Return asset
    Repo-->>Config: Return release details
    Config-->>CLI: Generate configuration
    CLI-->>Dev: Display result
Loading

Poem

🐰 Hop, hop, refactoring we go!

Commas dance, types align just so,
Nullable parameters take their bow,
Code style fixes make our rabbit proud now!

Whiskers twitch with pure delight 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dddbf4c and d791d23.

📒 Files selected for processing (77)
  • .editorconfig (1 hunks)
  • .gitattributes (1 hunks)
  • .github/FUNDING.yml (1 hunks)
  • .github/workflows/cs-fix.yml (1 hunks)
  • .github/workflows/psalm.yml (1 hunks)
  • .gitignore (1 hunks)
  • .php-cs-fixer.dist.php (1 hunks)
  • bin/rr (2 hunks)
  • composer.json (1 hunks)
  • psalm-baseline.xml (1 hunks)
  • psalm.xml (1 hunks)
  • src/Archive/Archive.php (1 hunks)
  • src/Archive/Factory.php (2 hunks)
  • src/Archive/FactoryInterface.php (1 hunks)
  • src/Archive/PharArchive.php (0 hunks)
  • src/Archive/PharAwareArchive.php (1 hunks)
  • src/Archive/TarPharArchive.php (0 hunks)
  • src/Archive/ZipPharArchive.php (0 hunks)
  • src/Command.php (1 hunks)
  • src/Command/ArchitectureOption.php (1 hunks)
  • src/Command/InstallationLocationOption.php (1 hunks)
  • src/Command/OperatingSystemOption.php (1 hunks)
  • src/Command/Option.php (2 hunks)
  • src/Command/OptionInterface.php (0 hunks)
  • src/Command/StabilityOption.php (2 hunks)
  • src/Command/VersionFilterOption.php (1 hunks)
  • src/Configuration/Generator.php (2 hunks)
  • src/Configuration/Plugins.php (1 hunks)
  • src/Configuration/Presets.php (1 hunks)
  • src/Configuration/Section/Amqp.php (1 hunks)
  • src/Configuration/Section/Beanstalk.php (1 hunks)
  • src/Configuration/Section/Boltdb.php (1 hunks)
  • src/Configuration/Section/Broadcast.php (1 hunks)
  • src/Configuration/Section/Endure.php (1 hunks)
  • src/Configuration/Section/Fileserver.php (2 hunks)
  • src/Configuration/Section/Grpc.php (1 hunks)
  • src/Configuration/Section/Http.php (2 hunks)
  • src/Configuration/Section/Jobs.php (1 hunks)
  • src/Configuration/Section/Kv.php (1 hunks)
  • src/Configuration/Section/Logs.php (1 hunks)
  • src/Configuration/Section/Metrics.php (1 hunks)
  • src/Configuration/Section/Nats.php (1 hunks)
  • src/Configuration/Section/Otel.php (2 hunks)
  • src/Configuration/Section/Redis.php (1 hunks)
  • src/Configuration/Section/Reload.php (1 hunks)
  • src/Configuration/Section/Rpc.php (1 hunks)
  • src/Configuration/Section/SectionInterface.php (1 hunks)
  • src/Configuration/Section/Server.php (1 hunks)
  • src/Configuration/Section/Service.php (2 hunks)
  • src/Configuration/Section/Sqs.php (2 hunks)
  • src/Configuration/Section/Status.php (1 hunks)
  • src/Configuration/Section/Tcp.php (1 hunks)
  • src/Configuration/Section/Temporal.php (1 hunks)
  • src/Configuration/Section/Version.php (1 hunks)
  • src/Configuration/Section/Websockets.php (1 hunks)
  • src/DownloadProtocBinaryCommand.php (9 hunks)
  • src/Environment/Architecture.php (1 hunks)
  • src/Environment/Enum.php (0 hunks)
  • src/Environment/Environment.php (1 hunks)
  • src/Environment/OperatingSystem.php (1 hunks)
  • src/Environment/Stability.php (0 hunks)
  • src/GetBinaryCommand.php (9 hunks)
  • src/MakeConfigCommand.php (2 hunks)
  • src/Repository/Asset.php (0 hunks)
  • src/Repository/AssetInterface.php (1 hunks)
  • src/Repository/AssetsCollection.php (2 hunks)
  • src/Repository/Collection.php (5 hunks)
  • src/Repository/GitHub/GitHubAsset.php (1 hunks)
  • src/Repository/GitHub/GitHubRelease.php (2 hunks)
  • src/Repository/GitHub/GitHubRepository.php (2 hunks)
  • src/Repository/Release.php (1 hunks)
  • src/Repository/ReleaseInterface.php (0 hunks)
  • src/Repository/ReleasesCollection.php (2 hunks)
  • src/Repository/RepositoriesCollection.php (0 hunks)
  • src/Repository/RepositoryInterface.php (0 hunks)
  • src/Repository/Version1/StaticRepository.php (2 hunks)
  • src/VersionsCommand.php (3 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@roxblnfk roxblnfk merged commit 61eec29 into 2.x Jan 28, 2025
2 of 3 checks passed
@roxblnfk roxblnfk deleted the code-style branch January 28, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant