Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor key generation classes #2284

Merged
merged 15 commits into from
Nov 10, 2024

Rename CertParams/BindingParams expiration property to key_expiration.

b5b6de2
Select commit
Loading
Failed to load commit list.
Merged

Refactor key generation classes #2284

Rename CertParams/BindingParams expiration property to key_expiration.
b5b6de2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 10, 2024 in 0s

84.81% (+0.14%) compared to 135775a

View this Pull Request on Codecov

84.81% (+0.14%) compared to 135775a

Details

Codecov Report

Attention: Patch coverage is 87.06564% with 67 lines in your changes missing coverage. Please review.

Project coverage is 84.81%. Comparing base (135775a) to head (b5b6de2).

Files with missing lines Patch % Lines
src/lib/keygen.cpp 81.63% 36 Missing ⚠️
src/lib/rnp.cpp 87.34% 21 Missing ⚠️
src/lib/key_material.cpp 84.00% 8 Missing ⚠️
src/lib/json-utils.cpp 97.72% 1 Missing ⚠️
src/lib/pgp-key.cpp 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2284      +/-   ##
==========================================
+ Coverage   84.67%   84.81%   +0.14%     
==========================================
  Files         116      116              
  Lines       23436    23292     -144     
==========================================
- Hits        19844    19755      -89     
+ Misses       3592     3537      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.