fix(datadog): allow empty datadog result. Fixes argoproj#1548

Signed-off-by: Ryan M Smith <[email protected]>

metricproviders/datadog/datadog_test.go

@@ -141,8 +141,7 @@ func TestRunSuite(t *testing.T) {
 			webServerResponse: `{"status":"ok","series":[{"pointlist":[]}]}`,
 			metric: v1alpha1.Metric{
 				Name:             "foo",
-				SuccessCondition: "resultPointer == nil",
-				FailureCondition: "result >= 0.05",
+				SuccessCondition: "resultPointer == nil || result < 0.05",
 				Provider: v1alpha1.MetricProvider{
 					Datadog: &v1alpha1.DatadogMetric{
 						Query: "avg:kubernetes.cpu.user.total{*}",
@@ -155,6 +154,25 @@ func TestRunSuite(t *testing.T) {
 			useEnvVarForKeys:        false,
 		},
 
+		// Validate nil pointer logic
+		{
+			webServerStatus:   200,
+			webServerResponse: `{"status":"ok","series":[{"pointlist":[]}]}`,
+			metric: v1alpha1.Metric{
+				Name:             "foo",
+				SuccessCondition: "resultPointer != nil && result < 0.05",
+				Provider: v1alpha1.MetricProvider{
+					Datadog: &v1alpha1.DatadogMetric{
+						Query: "avg:kubernetes.cpu.user.total{*}",
+					},
+				},
+			},
+			expectedIntervalSeconds: 300,
+			expectedValue:           "0",
+			expectedPhase:           v1alpha1.AnalysisPhaseFailed,
+			useEnvVarForKeys:        false,
+		},
+
 		// Implicitly succeed if no datapoints are returned
 		{
 			webServerStatus:   200,