Create current_path arrays on read #4342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
path.dup
is one of the biggest object allocators at runtime. The fact is, that value is rarely used. It's only used by the runtime to add paths to errors, and it's exposed viaextras: [:path]
,context[:current_path]
, and in trace payloads aspath: ...
.This PR creates
path
on-demand forextras: [:path]
andcontext[:current_path]
and removes it from trace payloads. (Those traces also getcontext
, so code that useddata[:path]
could usedata[:context][:current_path]
instead.)In my silly-large, all-overhead benchmark, this reduces allocations dramatically (ymmv 🍻):
TODO:
current_path
in ScopedContext will remove any performance gain, sinceContext#[]
callsScopedContext#key?
. Make this not so.data[:path]
?data[:path]
for compatibility, or rolling this into 2.1, or adding a compat module for tracers which putsdata[:context][:current_path]
intodata[:path]
LegacyTrace