Add some missing allocation constraints.

rmacnak · Nov 9, 2024 · ea97030 · ea97030
1 parent 9ca23b6
commit ea97030
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 5 deletions.
diff --git a/vm/allocation.h b/vm/allocation.h
@@ -5,7 +5,6 @@
 #ifndef VM_ALLOCATION_H_
 #define VM_ALLOCATION_H_
 
-#include "vm/assert.h"
 #include "vm/globals.h"
 
 namespace psoup {

diff --git a/vm/heap.h b/vm/heap.h
@@ -5,6 +5,7 @@
 #ifndef VM_HEAP_H_
 #define VM_HEAP_H_
 
+#include "vm/allocation.h"
 #include "vm/assert.h"
 #include "vm/flags.h"
 #include "vm/globals.h"
@@ -439,7 +440,7 @@ class Heap {
   DISALLOW_COPY_AND_ASSIGN(Heap);
 };
 
-class HandleScope {
+class HandleScope : public ValueObject {
  public:
   HandleScope(Heap* heap, Object* ptr) : heap_(heap) {
     ASSERT(heap_->handles_size_ < Heap::kHandlesCapacity);

diff --git a/vm/io_buffer.h b/vm/io_buffer.h
@@ -5,6 +5,9 @@
 #ifndef VM_IO_BUFFER_H_
 #define VM_IO_BUFFER_H_
 
+#include "vm/assert.h"
+#include "vm/globals.h"
+
 namespace psoup {
 
 enum Operation {

diff --git a/vm/math.h b/vm/math.h
@@ -8,12 +8,13 @@
 #include <limits>
 #include <type_traits>
 
+#include "vm/allocation.h"
 #include "vm/assert.h"
 #include "vm/globals.h"
 
 namespace psoup {
 
-class Math {
+class Math : public AllStatic {
  public:
   template <typename T>
   static inline bool AddHasOverflow(T left, T right, T* result) {

diff --git a/vm/message_loop_fuchsia.cc b/vm/message_loop_fuchsia.cc
@@ -11,6 +11,7 @@
 #include <zircon/status.h>
 #include <zircon/syscalls.h>
 
+#include "vm/assert.h"
 #include "vm/os.h"
 
 namespace psoup {

diff --git a/vm/os.h b/vm/os.h
@@ -5,11 +5,12 @@
 #ifndef VM_OS_H_
 #define VM_OS_H_
 
+#include "vm/allocation.h"
 #include "vm/globals.h"
 
 namespace psoup {
 
-class OS {
+class OS : public AllStatic {
  public:
   static void Startup();
   static void Shutdown();

diff --git a/vm/thread.h b/vm/thread.h
@@ -6,6 +6,7 @@
 #define VM_THREAD_H_
 
 #include "vm/allocation.h"
+#include "vm/assert.h"
 #include "vm/globals.h"
 
 #if defined(OS_ANDROID) || defined(OS_FUCHSIA) || defined(OS_LINUX) ||         \

diff --git a/vm/utils.h b/vm/utils.h
@@ -7,12 +7,13 @@
 
 #include <type_traits>
 
+#include "vm/allocation.h"
 #include "vm/assert.h"
 #include "vm/globals.h"
 
 namespace psoup {
 
-class Utils {
+class Utils : public AllStatic {
  public:
   template <typename T>
   static constexpr inline T RoundDown(T x, intptr_t n) {