Add function performing replacements in matching Image, Container and…

… Kubernetes components

This relies on the Docker Distribution library
to parse image references in order to detect if
they are absolute or relative.

See [1] for more details about the proposal.

[1] devfile/api#985 (comment)

Signed-off-by: Armel Soro <[email protected]>

pkg/devfile/parse.go

@@ -109,6 +109,15 @@ func ParseDevfileAndValidate(args parser.ParserArgs) (d parser.DevfileObj, varWa
 		varWarning = variables.ValidateAndReplaceGlobalVariable(d.Data.GetDevfileWorkspaceSpec())
 	}
 
+	// Use image names as selectors after variable substitution,
+	// as users might be using variables for image names.
+	if args.ImageNamesAsSelector != nil && args.ImageNamesAsSelector.Registry != "" {
+		err = replaceImageNames(&d, args.ImageNamesAsSelector.Registry, args.ImageNamesAsSelector.Tag)
+		if err != nil {
+			return d, varWarning, err
+		}
+	}
+
 	// generic validation on devfile content
 	err = validate.ValidateDevfileData(d.Data)
 	if err != nil {