fix: make post-versioning script also update tags on github #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 5.6.1 release failed to push because the `post-versioning` script did not update the tags made by `npx lerna version` - Added a new `scripts/get-version-tag.js` file that returns the current version tag by reading the version from the `@rjsf/utils` package - Added new `commit-package-changes` as a separate script to shorten the `post-versioning` script - Added new `update-version-tags` script that uses the `get-version-tags.js` script to force update the local and remote tags to the current head - Updated `package*.json` to add `cross-env` so that the setting of the CI variable in `commit-package-changes` works on all environments - Updated the `CHANGELOG.md` file accordingly
heath-freenome
force-pushed
the
fix-tagging-in-post-version
branch
from
b181ac3 to
2522f47
Compare
heath-freenome
commented
Apr 18, 2023
heath-freenome
commented
Apr 18, 2023
nickgros
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
The 5.6.1 release failed to publish because the
post-versioningscript did not update the tags made bynpx lerna versionscripts/get-version-tag.jsfile that returns the current version tag by reading the version from the@rjsf/utilspackagecommit-package-changesas a separate script to shorten thepost-versioningscriptupdate-version-tagsscript that uses theget-version-tags.jsscript to force update the local and remote tags to the current headpackage*.jsonto addcross-envso that the setting of the CI variable incommit-package-changesworks on all environmentsCHANGELOG.mdfile accordinglyChecklist
npm run test:updateto update snapshots, if needed.