Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@rjsf-antd): Submit button type bug (#2867) #2869

Merged
merged 9 commits into from
May 25, 2022
Merged

fix(@rjsf-antd): Submit button type bug (#2867) #2869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
afdd34c
Submit button type bug fix
sarpere May 23, 2022
4729872
Submit button type bug fix
sarpere May 23, 2022
86bbc7d
Merge branch 'rjsf-antd-submit-bug' of https://github.com/sarpere/rea…
sarpere May 23, 2022
feccf46
Merge branch 'rjsf-antd-submit-bug' of https://github.com/sarpere/rea…
sarpere May 23, 2022
535fa5a
Merge branch 'rjsf-antd-submit-bug' of https://github.com/sarpere/rea…
sarpere May 23, 2022
9912e66
Revert "Submit button type bug fix"
sarpere May 23, 2022
7c68bfe
Submit button type fix
sarpere May 23, 2022
45db00c
White space removed
sarpere May 24, 2022
7edad15
antd test snapshots update
sarpere May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/antd/src/widgets/SubmitButton/SubmitButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const { getSubmitButtonOptions } = utils;
export default ({ uiSchema }) => {
const { submitText, norender, props: submitButtonProps }= getSubmitButtonOptions(uiSchema);
if (norender) {return null;}
return (<Button type="submit" {...submitButtonProps}>
return (<Button htmlType="submit" {...submitButtonProps}>
{submitText}
</Button>);
};
Expand Down
12 changes: 6 additions & 6 deletions packages/antd/test/__snapshots__/Array.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ exports[`array fields array 1`] = `
</fieldset>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down Expand Up @@ -186,10 +186,10 @@ exports[`array fields checkboxes 1`] = `
</div>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down Expand Up @@ -460,10 +460,10 @@ exports[`array fields fixed array 1`] = `
</fieldset>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down
44 changes: 22 additions & 22 deletions packages/antd/test/__snapshots__/Form.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,10 @@ exports[`single fields field with description 1`] = `
</fieldset>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down Expand Up @@ -204,10 +204,10 @@ exports[`single fields field with description in uiSchema 1`] = `
</fieldset>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down Expand Up @@ -240,10 +240,10 @@ exports[`single fields hidden field 1`] = `
</fieldset>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand All @@ -262,10 +262,10 @@ exports[`single fields null field 1`] = `
className="form-group field field-null"
/>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down Expand Up @@ -393,10 +393,10 @@ exports[`single fields number field 1`] = `
</div>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down Expand Up @@ -428,10 +428,10 @@ exports[`single fields string field format data-url 1`] = `
</div>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down Expand Up @@ -469,10 +469,10 @@ exports[`single fields string field format email 1`] = `
/>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down Expand Up @@ -510,10 +510,10 @@ exports[`single fields string field format uri 1`] = `
/>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down Expand Up @@ -551,10 +551,10 @@ exports[`single fields string field regular 1`] = `
/>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down Expand Up @@ -596,10 +596,10 @@ exports[`single fields unsupported field 1`] = `
</div>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down Expand Up @@ -637,10 +637,10 @@ exports[`single fields using custom tagName 1`] = `
/>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down
4 changes: 2 additions & 2 deletions packages/antd/test/__snapshots__/Object.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,10 +253,10 @@ exports[`object fields object 1`] = `
</fieldset>
</div>
<button
className="ant-btn ant-btn-submit"
className="ant-btn"
disabled={false}
onClick={[Function]}
type="button"
type="submit"
>
<span>
Submit
Expand Down