Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide tsdx build format arg to build UMD #2810

Closed
wants to merge 2 commits into from
Closed

provide tsdx build format arg to build UMD #2810

wants to merge 2 commits into from

Conversation

stringfellow
Copy link
Contributor

Reasons for making this change

Adds build format 'UMD' to tsdx build command - fixes #2110 - making UMD modules available on CDNs and for use with e.g. requirejs.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@stringfellow stringfellow mentioned this pull request Apr 12, 2022
Closed
3 tasks
@nickgros nickgros mentioned this pull request Apr 15, 2022
Merged
8 tasks
nickgros
nickgros approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll make sure to include the changes across the rest of the packages in #2799

@nickgros
Copy link
Contributor

Added in v4.2.1. Thanks @stringfellow !

@nickgros nickgros closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickgros nickgros nickgros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bootstrap-4] No UMD dist for bootstrap-4 theme
2 participants
@stringfellow @nickgros