Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Link for Custom Widgets and Fields in UISchema Page #3553

Closed
3 of 4 tasks
Sachin-chaurasiya opened this issue Mar 28, 2023 · 7 comments · Fixed by #3574
Closed
3 of 4 tasks

Broken Link for Custom Widgets and Fields in UISchema Page #3553

Sachin-chaurasiya opened this issue Mar 28, 2023 · 7 comments · Fixed by #3574

Comments

@Sachin-chaurasiya
Copy link

Prerequisites

What theme are you using?

antd

Version

5.0.0-beta.13

Current Behavior

Currently the link for Custom Widgets and Fields in UISchema doc page is broken.

It is redirecting to https://rjsf-team.github.io/react-jsonschema-form/docs/api-reference/advanced-customization/custom-widgets-fields#custom-field-components.

Expected Behavior

It should redirect to https://rjsf-team.github.io/react-jsonschema-form/docs/advanced-customization/custom-widgets-fields

Steps To Reproduce

Environment

- OS:
- Node:
- npm:

Anything else?

I would like to work on this issue.

@Sachin-chaurasiya Sachin-chaurasiya added bug needs triage Initial label given, to be assigned correct labels and assigned labels Mar 28, 2023
@heath-freenome
Copy link
Member

@Sachin-chaurasiya Yes, please submit a fix!

@heath-freenome heath-freenome added help wanted docs and removed needs triage Initial label given, to be assigned correct labels and assigned labels Mar 30, 2023
Sachin-chaurasiya added a commit to Sachin-chaurasiya/react-jsonschema-form that referenced this issue Mar 31, 2023
fix(rjsf-team#3553):Broken Link for Custom Widgets and Fields in UISchema Page
@Sachin-chaurasiya
Copy link
Author

@Sachin-chaurasiya Yes, please submit a fix!

Thanks @heath-freenome , Here is the PR

@heath-freenome
Copy link
Member

@Sachin-chaurasiya After further review, I'm thinking that the behavior you are reporting as a bug is probably not one. The field prop in the UiSchema should point to the fields section of the documentation. What makes you think that the link was wrong?

@Sachin-chaurasiya
Copy link
Author

@Sachin-chaurasiya After further review, I'm thinking that the behavior you are reporting as a bug is probably not one. The field prop in the UiSchema should point to the fields section of the documentation. What makes you think that the link was wrong?

@heath-freenome , It was redirecting to this link , which is broken.

@heath-freenome
Copy link
Member

@Sachin-chaurasiya After further review, I'm thinking that the behavior you are reporting as a bug is probably not one. The field prop in the UiSchema should point to the fields section of the documentation. What makes you think that the link was wrong?

@heath-freenome , It was redirecting to this link , which is broken.

@Sachin-chaurasiya the links in the source code .md files aren't meant to be clicked on. The source is compiled into a release and deployed here. If you look at the documentation site for the page you are referring to and click the link it works.

@Sachin-chaurasiya
Copy link
Author

@Sachin-chaurasiya After further review, I'm thinking that the behavior you are reporting as a bug is probably not one. The field prop in the UiSchema should point to the fields section of the documentation. What makes you think that the link was wrong?

@heath-freenome , It was redirecting to this link , which is broken.

@Sachin-chaurasiya the links in the source code .md files aren't meant to be clicked on. The source is compiled into a release and deployed here. If you look at the documentation site for the page you are referring to and click the link it works.

@heath-freenome , I have opened an issue for this link, please see the attached recording.

Screen.Recording.2023-04-04.at.10.59.36.AM.mov

@heath-freenome
Copy link
Member

@Sachin-chaurasiya Ah! I know what is going on. For some reason the links when you click on a subsection end up with a / before the #link so the relative locations stop working. If you clear the /#link from the url then things are fine. I'm going to see if there is a configuration switch to prevent the / before the #link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants