Fix vulnerabilities on several components #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wargio
requested review from
ret2libc,
thestr4ng3r,
XVilka and
kazarmy
as code owners
XVilka
approved these changes
Aug 17, 2022
When the individual n_slide_infos were too high, the sum would overflow and too few entries would be allocated.
thestr4ng3r
force-pushed
the
fuzz-fix-vulns
branch
from
6ad60d9 to
bb33d47
Compare
thestr4ng3r
approved these changes
Aug 17, 2022
|
To be cherry-picked for 0.4.1 |
socketpair
reviewed
Aug 17, 2022
|
|
||
| if (is_func) { | ||
| bin_sec->perm = RZ_PERM_R | RZ_PERM_X; | ||
| } else { | ||
| bin_sec->perm = RZ_PERM_R; | ||
| } | ||
|
|
||
| rz_list_append(section_list, bin_sec); | ||
| if (!rz_list_append(section_list, bin_sec)) { | ||
| rz_bin_section_free(bin_sec); |
There was a problem hiding this comment.
no need. tbh, the code needs a lot of love.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
...