Handle image loading failure (empty body or statusCode other than 200) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test case that tests the problem this PR is fixing. |
|
test case with an URL leading to 404 added |
|
Thanks for your contribution! We'll triage and take a look at it as soon as possible! |
riyadhalnur
added a commit
that referenced
this pull request
Feb 4, 2016
Handle image loading failure (empty body or statusCode other than 200)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases when the image could not be loaded and (body && res.statusCode === 200) was not true, no error was thrown and callback was never called.