Skip to content

Commit

Permalink
editor+runtime: allow setting tolerance to path measure
Browse files Browse the repository at this point in the history 
Before this PR, sometimes the movement on a path can be choppy, and this is noticeable everywhere I tested on mac, web, runtime:
https://github.com/user-attachments/assets/a396544a-40c1-4921-be11-01c978f50b4a
https://github.com/user-attachments/assets/78c54a00-b82f-42fe-ab85-f87961cccd62

This is because the default tolerance on the path measure is 0.5, which is too high. Making this 0.1 is smoother (tho probably less performant). I only changed this for text follow path, because it's more noticeable there.

After, on mac, web, runtime:
https://github.com/user-attachments/assets/99db7f81-27f6-46a9-b70c-bfe8ecb59933
https://github.com/user-attachments/assets/34b65a34-ff9e-40a0-a7c1-827146609d03
https://github.com/user-attachments/assets/be224730-dfba-4b1b-8d8a-c08dd48d8fa7

Diffs=
cfde2d5136 editor+runtime: allow setting tolerance to path measure (#9102)
  • Loading branch information
susan101566 committed Feb 25, 2025
1 parent 779f0c7 commit 48033a2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2e739a03582570fdcd70bb46588168b578ede8d2
cfde2d5136e3fef2a27409c25fc002cbefe50398
2 changes: 1 addition & 1 deletion wasm/submodules/rive-runtime
Submodule rive-runtime updated 4 files
+1 −1 .rive_head
+2 −1 include/rive/math/path_measure.hpp
+2 −2 src/math/path_measure.cpp
+1 −1 src/text/text_follow_path_modifier.cpp

0 comments on commit 48033a2

Please sign in to comment.