Skip to content

Commit

Permalink
imagediff -> opencv
Browse files Browse the repository at this point in the history 
Removed need for imagediff and skia, now using imageDiff.py and opencv / numpy

This removes the need to build skia for check_golds. However, it does add a dependency on opencv so pip is once again needed. It's only needed for testing though, so it should be much more manageable.

To get around this we can build python-opencv ourselves following the manual build instructions [here](https://pypi.org/project/opencv-python/). However, that would be quite a large build time, and I don't think it's quite necessary.

Diffs=
a02ac789ca imagediff -> opencv (#8397)
  • Loading branch information
blakdragan7 committed Oct 26, 2024
1 parent eb985cc commit fcb89f0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4fec171eac63c83a5c0a6d7abb3df0945d82775c
a02ac789ca472a5ac72bb3f0a5585fd3f243f095
2 changes: 1 addition & 1 deletion submodules/rive-runtime
Submodule rive-runtime updated 5 files
+1 −1 .rive_head
+33 −20 tests/diff.py
+110 −0 tests/image_diff.py
+0 −45 tests/premake5.lua
+0 −2 tests/rive_tools_project.lua

0 comments on commit fcb89f0

Please sign in to comment.