Skip to content

Commit

Permalink
Get rid of MetricsPath.
Browse files Browse the repository at this point in the history
This lets us trim a raw path directly which means all the trim path logic from the editor can now be pushed down to the C++ runtime, even for the case where the rendering is still happening via Skia/Impeller, all our path operations can be done in C++ (without using RenderPath/MetricsPath/RenderMetricsPath/OnlyMetricsPath/etc). Basically, I needed to do this now to not have as many edge cases in the editor for the difference between using our runtime to render with PLS vs Flutter.

It also quite greatly simplifies the code! More lines removed than added!

Some tests will fail as I think we're using the MetricsPath in some other parts of the code, but that can be refactored following the patterns used here...

It also means that most of our runtime now speaks RawPath which means we can optimize/reserve memory ahead of time in a lot of cases (not doing that yet).

Diffs=
8486c3445 Get rid of MetricsPath. (#7371)
  • Loading branch information
luigi-rosso committed Jun 7, 2024
1 parent 282c037 commit c463657
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
085f5bd2dce2d25561b00eebc5f7118a2c8769eb
8486c344528d5f7f84de1984510064a7d0788e73
2 changes: 1 addition & 1 deletion .rive_renderer
Original file line number Diff line number Diff line change
@@ -1 +1 @@
97fdd91ecb8e839bd48fb2076aae4b0c6f9db5f0
648acb22250fe2b20e548c2e603a8c75b44f5652
2 changes: 1 addition & 1 deletion submodules/rive-cpp

0 comments on commit c463657

Please sign in to comment.