Skip to content

Commit

Permalink
Fix issue with timeline events on first frame
Browse files Browse the repository at this point in the history
Events that fire on the first frame (with a work area too) were not reporting. This was because the way we look for occurred events wouldn't catch an event that started at the same time as the playhead as presumably that would've been caught on the previous frame. This falls apart when the animation starts on the same frame as the one where an event (or multiple) are triggered.

Adds a fix by detecting this condition and a bunch of tests in both C++ and Dart for it.

Also revs the lightning bolt animation in the editor for triggering the event as this showed an issue with state contention in its state machine.

Diffs=
382a48cf8 Fix issue with timeline events on first frame (#6006)
  • Loading branch information
luigi-rosso committed Sep 19, 2023
1 parent ae7d2ea commit c2c67f2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1f0ccae8d1a8c32f2762a575c6fb0e4e8c5d201f
382a48cf8c79664cc8d5308f2f0a4a504d33b2be
2 changes: 1 addition & 1 deletion .rive_renderer
Original file line number Diff line number Diff line change
@@ -1 +1 @@
01aa67c9996f1fa96ac8091040dfc91d432192e9
cc97fb44964df4439e3bc1a35d9c7944350d7aa8
2 changes: 1 addition & 1 deletion submodules/rive-cpp

0 comments on commit c2c67f2

Please sign in to comment.