Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix directorapi #374

Merged
merged 4 commits into from
Apr 2, 2022
Merged

Fix directorapi #374

merged 4 commits into from
Apr 2, 2022

Conversation

xiaoxiao921
Copy link
Member

  • Port stages that were still using the old spawning system to the new one, this effectively break again the methods but the API overall is now much easier to use than before.
  • Fix null exceptions that could occur within the Simulacrum game mode.

tristanmcpherson
tristanmcpherson approved these changes Apr 2, 2022
View reviewed changes
Copy link
Member

@tristanmcpherson tristanmcpherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this seems like a better approach. Good work, thanks

@tristanmcpherson tristanmcpherson merged commit d2b2091 into risk-of-thunder:master Apr 2, 2022
@tristanmcpherson tristanmcpherson mentioned this pull request Apr 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanmcpherson tristanmcpherson tristanmcpherson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoxiao921 @tristanmcpherson