Allow default idrs opt out #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for character modders
|
Looks good to me but should we really provide an overload with charModel name ? Ideally the whole system is supposed to reason only with those since char models can have the same name but be totally different looking. See engi turrets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some character mods have exported their model really tiny (or large) and this messes with default IDRS on those characters. The resulting default rulesets will blow up making the game unplayable when such an item is picked up.
So while those mods should really fix their model, it's a minor effort on our end to let them opt out of being assigned default rulesets.
(Also stops allocating memory bodyprefab * 2 * (items+equipment) times for
.nameand instead just is bodyprefab * 2 allocations)