Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecalculateStatsAPI: Add Extra stat customization points. #322

Merged
merged 7 commits into from
Dec 16, 2021

Conversation

yekoc
Copy link
Contributor

@yekoc yekoc commented Dec 14, 2021

Adds more things to RecalculateStatsAPI.
Currently the following:
Curse
Shield Multiplier
All manner of Cooldown Reduction
Flat Jump Power (someone probably has a use for this,somewhere)
Level Scaling (How much each level matters,rather than modifying the current level,since that can already be changed)
Root,the implementation of which might have been better,but I hope that the way it is ends up working well.

These are all seperate commits for convenience reasons.While I haven't tested them seperately all the commits should be buildable by themselves.

*StatHookEventArgs now include baseCurseAdd,which is directly added to
CharacterBody.cursePenalty,users should be careful to not accidentally
obliterate the players health bar,the power to do so was kept since
Shaped Glass can also do it.
* Adds the following to StatHookEventArgs;
  - cooldownReductionAdd : is directly added to flat cooldown reduction
    on all skills
  - cooldownMultAdd : is directly added to the multiplier for cooldown
    durations on all skills
  - primaryCooldownMultAdd,
    secondaryCooldownMultAdd,  :same as cooldownMultAdd,but
    utilityCooldownMultAdd,           skill specific
    specialCooldownMultAdd
* It was previously only possible to add a flat amount of shield,now
  StatHookEventArgs includes shieldMultAdd,which is directly added to a
  new,direct,multiplier for shields
*It was previously only possible to increase jump power by a multiple,
StatHookEventArgs now contains baseJumpPowerAdd,which allows for static
amounts of extra lift.
*StatHookEventArgs now contains levelMultAdd,which is directly added to
the multiplier defining how a body's level contributes to it's
stats,thus modifying this value can allow changing the 'effective level'
of a given body to something else and even allow fractional levels.
*Adds moveSpeedRootCount to StatHookEventArgs, a counter that can be incremented to root the body in place in
accordance to similar vanilla mechanics,it is a counter instead of a
bool to hopefully facilitate less accidental overwrites of another
effect.
@CLAassistant
Copy link

CLAassistant commented Dec 14, 2021

CLA assistant check
All committers have signed the CLA.

*Was targeting the wrong instruction due to having forgotten to actually
move to the end of the block we found.whoops?
@tristanmcpherson tristanmcpherson merged commit a0f1ea2 into risk-of-thunder:master Dec 16, 2021
@yekoc yekoc deleted the more_recalculation branch March 5, 2022 15:26
@yekoc yekoc restored the more_recalculation branch March 5, 2022 15:26
@yekoc yekoc deleted the more_recalculation branch March 5, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants