Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnlockablesAPI #156

Merged
merged 4 commits into from
Jul 10, 2020
Merged

Add UnlockablesAPI #156

merged 4 commits into from
Jul 10, 2020

Conversation

Reinms
Copy link
Contributor

@Reinms Reinms commented Jul 10, 2020

Allows mods to easily add custom achievements and unlockables, could do with a bit of extra testing to be on safe side.

I have some example code I can put on wiki if needed. It is fairly straightforward though.

@harbingerofme
Copy link
Collaborator

Please make public facing fields and properties capitalized

@Reinms
Copy link
Contributor Author

Reinms commented Jul 10, 2020

One override can't be capitalized since it's defined in ror2.

@tristanmcpherson
Copy link
Member

One override can't be capitalized since it's defined in ror2.

No complaints in that case. Looks nice and clean. Good work.

@tristanmcpherson tristanmcpherson merged commit 5805050 into risk-of-thunder:master Jul 10, 2020
@Reinms
Copy link
Contributor Author

Reinms commented Jul 10, 2020

Just to be clear, I tested a lot of the use cases I could think of, but it would be good to have some other people try to break it before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants