Integrate assetplus into main repo and seperate it's components #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you do this https://github.com/risk-of-thunder/R2API/blob/master/R2API/ItemAPI.cs#L185 instead of R2API/R2API/Utils/APISubmodule.cs Line 115 in 69ead86 |
This reverts commit 78539c9.
|
That would break the mods that use AssetPlusRequester as they depend on the auto loading of certain filetypes, could enable the submodule if at least one of those files is in the plugin folder |
tristanmcpherson
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reworked LanguagePlus to no longer need to reload language, old functions now redirects to new functions