ModListAPI fix, APISubmodule changes, ItemAPI fix. Code writing style cleanup. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uleSet available.
- Make code writing style more consistent with the R2API project. - Fix null ref with null SteamId
- added IsLoaded(nameof submodule) method to check if a submodule is loaded for mod makers - added some xml docs
- Fixes some access modifiers being incorrect
|
Good stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make code writing style more consistent with the R2API project.
Fix some access modifiers being incorrect.
ModListAPI
File got renamed, to see the commit diff please check the commit directly 7497b99
Fix null ref exception
ItemAPI
Add a null check when custom player models don't have an ItemDisplayRuleSet available.
APISubmoduleHandler
Add IsLoaded(nameof submodule) method to check if a submodule is loaded for mod makers.
Add some xml docs and remove some debug lines that are kinda redundant.