Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plan_node): Share-related nodes refactoring. #9715

Merged
merged 20 commits into from
May 10, 2023
Merged

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented May 9, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Follow up of #8898, #8870, #8905, #8930, #8932, #9011, #9044, #9176.
This PR simplifies the initialization of share-related nodes.

Checklist For Contributors

  • Yes

Documentation

  • My PR DOES NOT contain user-facing changes.

@ice1000
Copy link
Contributor Author

ice1000 commented May 9, 2023

Lots of code are moved from logical_scan.rs into generic/scan.rs.

@ice1000 ice1000 requested a review from st1page May 9, 2023 20:14
@ice1000 ice1000 enabled auto-merge May 10, 2023 11:54
@ice1000 ice1000 added this pull request to the merge queue May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #9715 (e052c3f) into main (f512021) will decrease coverage by 0.01%.
The diff coverage is 94.17%.

@@            Coverage Diff             @@
##             main    #9715      +/-   ##
==========================================
- Coverage   70.99%   70.98%   -0.01%     
==========================================
  Files        1245     1245              
  Lines      208372   208369       -3     
==========================================
- Hits       147927   147913      -14     
- Misses      60445    60456      +11     
Flag Coverage Δ
rust 70.98% <94.17%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/optimizer/plan_node/stream_temporal_join.rs 63.52% <33.33%> (ø)
...nd/src/optimizer/plan_visitor/sys_table_visitor.rs 58.82% <50.00%> (ø)
.../optimizer/plan_visitor/temporal_join_validator.rs 80.00% <50.00%> (ø)
...c/frontend/src/optimizer/plan_node/logical_scan.rs 90.62% <88.88%> (-5.48%) ⬇️
...frontend/src/optimizer/plan_node/batch_seq_scan.rs 95.60% <94.11%> (-0.17%) ⬇️
...ntend/src/optimizer/plan_node/stream_table_scan.rs 96.66% <94.11%> (-0.20%) ⬇️
...c/frontend/src/optimizer/plan_node/generic/scan.rs 96.61% <95.53%> (-3.39%) ⬇️
src/frontend/src/optimizer/mod.rs 92.37% <100.00%> (ø)
.../frontend/src/optimizer/plan_node/generic/share.rs 100.00% <100.00%> (ø)
...c/frontend/src/optimizer/plan_node/logical_join.rs 89.60% <100.00%> (ø)
... and 10 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 8874bf5 May 10, 2023
@ice1000 ice1000 deleted the tesla/share branch May 10, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants