-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fe): refine notice framework #9705
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9705 +/- ##
==========================================
- Coverage 70.97% 70.95% -0.02%
==========================================
Files 1241 1241
Lines 207703 207701 -2
==========================================
- Hits 147412 147384 -28
- Misses 60291 60317 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In the previous notice implementation #9577, we can not notice user when the optimizer throws an error.
SessionImpl
and add a interface on thetrait pgwire::Session
warn
towarn_to_user
Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note