Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): refine notice framework #9705

Merged
merged 5 commits into from
May 10, 2023
Merged

feat(fe): refine notice framework #9705

merged 5 commits into from
May 10, 2023

Conversation

st1page
Copy link
Contributor

@st1page st1page commented May 9, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In the previous notice implementation #9577, we can not notice user when the optimizer throws an error.

  • add the warning messages in the SessionImpl and add a interface on the trait pgwire::Session
  • rename the warn to warn_to_user

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@st1page st1page changed the title feature refine notice feature(fe): refine notice framework May 9, 2023
@st1page st1page requested a review from TennyZhuang May 9, 2023 09:18
@st1page st1page marked this pull request as ready for review May 9, 2023 09:18
@st1page st1page requested a review from jon-chuang May 9, 2023 09:23
@st1page st1page changed the title feature(fe): refine notice framework feat(fe): refine notice framework May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #9705 (4f64b6a) into main (0ff65d1) will decrease coverage by 0.02%.
The diff coverage is 65.38%.

@@            Coverage Diff             @@
##             main    #9705      +/-   ##
==========================================
- Coverage   70.97%   70.95%   -0.02%     
==========================================
  Files        1241     1241              
  Lines      207703   207701       -2     
==========================================
- Hits       147412   147384      -28     
- Misses      60291    60317      +26     
Flag Coverage Δ
rust 70.95% <65.38%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/query.rs 27.01% <0.00%> (ø)
src/frontend/src/optimizer/plan_node/convert.rs 83.67% <0.00%> (ø)
src/frontend/src/session.rs 27.27% <43.75%> (+0.36%) ⬆️
src/utils/pgwire/src/pg_protocol.rs 53.48% <60.00%> (-0.10%) ⬇️
src/frontend/src/handler/create_mv.rs 95.37% <100.00%> (-0.17%) ⬇️
src/frontend/src/handler/create_table.rs 89.77% <100.00%> (-0.10%) ⬇️
src/frontend/src/optimizer/optimizer_context.rs 89.23% <100.00%> (+0.17%) ⬆️
src/utils/pgwire/src/pg_server.rs 81.52% <100.00%> (+0.35%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@st1page st1page added this pull request to the merge queue May 10, 2023
Merged via the queue into main with commit fb1b09f May 10, 2023
@st1page st1page deleted the sts/refine_notice branch May 10, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants