feat(concat delete iterator): prefetch for concat delete range iterator #9693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
background: #9517 (comment)
However, when
read_options.ignore_range_tombstone == false
, concat delete range iterator will usually request forSstableMeta
of an SST earlier thanSstableMeta
of the same SST is requested for by concat iterator.Therefore, in such situation, prefetching in
ConcatDeleteRangeIterator
is meaningful and prefetching inConcatIterator
is meaningless.This PR makes
ConcatDeleteRangeIterator
prefetch one extraSSTableMeta
every time it requests for anSSTableMeta
.This PR maintains a prefetch queue (
prefetched_metas: VecDeque
) forSSTableMeta
s that have already been prefetched.Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note