fix(storage): do not fetch all sst meta when create iterator #9517
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| // Copyright 2023 RisingWave Labs | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| use std::future::Future; | ||
|
|
||
| use risingwave_hummock_sdk::key::{FullKey, PointRange, UserKey}; | ||
| use risingwave_hummock_sdk::HummockEpoch; | ||
| use risingwave_pb::hummock::SstableInfo; | ||
|
|
||
| use crate::hummock::iterator::DeleteRangeIterator; | ||
| use crate::hummock::sstable_store::SstableStoreRef; | ||
| use crate::hummock::{HummockResult, SstableDeleteRangeIterator}; | ||
| use crate::monitor::StoreLocalStatistic; | ||
|
|
||
| pub struct ConcatDeleteRangeIterator { | ||
| sstables: Vec<SstableInfo>, | ||
| current: Option<SstableDeleteRangeIterator>, | ||
| idx: usize, | ||
| sstable_store: SstableStoreRef, | ||
| stats: StoreLocalStatistic, | ||
| } | ||
|
|
||
| impl ConcatDeleteRangeIterator { | ||
| pub fn new(sstables: Vec<SstableInfo>, sstable_store: SstableStoreRef) -> Self { | ||
| Self { | ||
| sstables, | ||
| sstable_store, | ||
| stats: StoreLocalStatistic::default(), | ||
| idx: 0, | ||
| current: None, | ||
| } | ||
| } | ||
|
|
||
| /// Seeks to a table, and then seeks to the key if `seek_key` is given. | ||
| async fn seek_idx( | ||
| &mut self, | ||
| idx: usize, | ||
| seek_key: Option<UserKey<&[u8]>>, | ||
| ) -> HummockResult<()> { | ||
| self.current.take(); | ||
| if idx < self.sstables.len() { | ||
| if self.sstables[idx].range_tombstone_count == 0 { | ||
| return Ok(()); | ||
| } | ||
| let table = self | ||
| .sstable_store | ||
| .sstable(&self.sstables[idx], &mut self.stats) | ||
| .await?; | ||
| let mut sstable_iter = SstableDeleteRangeIterator::new(table); | ||
|
|
||
| if let Some(key) = seek_key { | ||
| sstable_iter.seek(key).await?; | ||
| } else { | ||
| sstable_iter.rewind().await?; | ||
| } | ||
|
|
||
| self.current = Some(sstable_iter); | ||
| self.idx = idx; | ||
| } | ||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| impl DeleteRangeIterator for ConcatDeleteRangeIterator { | ||
| type NextFuture<'a> = impl Future<Output = HummockResult<()>> + 'a; | ||
| type RewindFuture<'a> = impl Future<Output = HummockResult<()>> + 'a; | ||
| type SeekFuture<'a> = impl Future<Output = HummockResult<()>> + 'a; | ||
|
|
||
| fn next_extended_user_key(&self) -> PointRange<&[u8]> { | ||
| self.current.as_ref().unwrap().next_extended_user_key() | ||
| } | ||
|
|
||
| fn current_epoch(&self) -> HummockEpoch { | ||
| self.current.as_ref().unwrap().current_epoch() | ||
| } | ||
|
|
||
| fn next(&mut self) -> Self::NextFuture<'_> { | ||
| async { | ||
| if let Some(iter) = self.current.as_mut() { | ||
| if iter.is_valid() { | ||
| iter.next().await?; | ||
Little-Wallace marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } else { | ||
| let mut idx = self.idx; | ||
| while idx + 1 < self.sstables.len() && !self.is_valid() { | ||
| self.seek_idx(idx + 1, None).await?; | ||
| idx += 1; | ||
| } | ||
| } | ||
| } | ||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| fn rewind(&mut self) -> Self::RewindFuture<'_> { | ||
| async move { | ||
| let mut idx = 0; | ||
| while idx < self.sstables.len() && self.sstables[idx].range_tombstone_count == 0 { | ||
| idx += 1; | ||
| } | ||
| self.current.take(); | ||
| self.seek_idx(0, None).await?; | ||
Little-Wallace marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| while idx + 1 < self.sstables.len() && !self.is_valid() { | ||
Little-Wallace marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| self.seek_idx(idx + 1, None).await?; | ||
| idx += 1; | ||
| } | ||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| fn seek<'a>(&'a mut self, target_user_key: UserKey<&'a [u8]>) -> Self::SeekFuture<'_> { | ||
| async move { | ||
| let mut idx = self | ||
| .sstables | ||
| .partition_point(|sst| { | ||
| FullKey::decode(&sst.key_range.as_ref().unwrap().left) | ||
| .user_key | ||
| .le(&target_user_key) | ||
| }) | ||
| .saturating_sub(1); // considering the boundary of 0 | ||
Little-Wallace marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| self.current.take(); | ||
Little-Wallace marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| self.seek_idx(idx, Some(target_user_key)).await?; | ||
| while idx + 1 < self.sstables.len() && !self.is_valid() { | ||
| self.seek_idx(idx + 1, None).await?; | ||
| idx += 1; | ||
| } | ||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| fn is_valid(&self) -> bool { | ||
| self.current | ||
| .as_ref() | ||
| .map(|iter| iter.is_valid()) | ||
| .unwrap_or(false) | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In current implementation, after a
nextcall,next_extended_user_keymay stay invariant. Is this bad-taste?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But everywhere we call
next_extended_user_keywould always collect all keys whose user-key equalsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
MergeIterator, everywhere we callnext_extended_user_keywould always collect all keys IN OTHER ITERATORS whose user-key equals, but except the iterator itself