Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plan_node): reorganize and simplify source-related nodes #9209

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Apr 15, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Follow up of #8898, #8870, #8905, #8930, #8932, #9011, #9044, #9176.

Checklist For Contributors

  • Yes

Documentation

  • My PR DOES NOT contain user-facing changes.

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #9209 (7b169b6) into main (59621a6) will decrease coverage by 0.01%.
The diff coverage is 83.92%.

@@            Coverage Diff             @@
##             main    #9209      +/-   ##
==========================================
- Coverage   70.83%   70.82%   -0.01%     
==========================================
  Files        1201     1201              
  Lines      200425   200407      -18     
==========================================
- Hits       141971   141943      -28     
- Misses      58454    58464      +10     
Flag Coverage Δ
rust 70.82% <83.92%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/scheduler/plan_fragmenter.rs 66.71% <0.00%> (ø)
...timizer/plan_visitor/relation_collector_visitor.rs 69.69% <50.00%> (ø)
...frontend/src/optimizer/plan_node/generic/source.rs 93.54% <66.66%> (-6.46%) ⬇️
...c/frontend/src/optimizer/plan_node/batch_source.rs 70.96% <83.33%> (+7.63%) ⬆️
...frontend/src/optimizer/plan_node/logical_source.rs 70.67% <100.00%> (-1.07%) ⬇️
.../frontend/src/optimizer/plan_node/stream_source.rs 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ice1000 ice1000 enabled auto-merge April 16, 2023 02:27
@ice1000 ice1000 requested a review from st1page April 16, 2023 02:27
@ice1000 ice1000 added this pull request to the merge queue Apr 17, 2023
Merged via the queue into main with commit 1355133 Apr 17, 2023
@ice1000 ice1000 deleted the tesla/lollol branch April 17, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants